Update the README for the github-actions package to be based on Node.js v20
#123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemd24
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Hi @eason9487, thanks for updating the readme file. I left a comment about installing v18 (compatible). Everything else looks good to me.
packages/github-actions/README.md
Outdated
|
|
||
| ### JavaScript actions | ||
|
|
||
| 1. Install `node` with version >= 14 | ||
| 1. Install `node` with version v20 (recommended) or v18 (compatible) |
There was a problem hiding this comment.
Why not just go with v20? Otherwise, which specific version of v18 can I install or is compatible?
There was a problem hiding this comment.
Node.js v18 was listed because it's also compatible to use in development. Considering the End-of-Life date for v18 is within a year, it should be better to recommend v20 only. Thanks for the suggestion! Adjusted in c97deef.
… `github-actions` package. Address: #123 (comment)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Part of #108
This PR updates the README for the
github-actionspackage to be based on Node.js v20Detailed test instructions:
Read the updated README to see if it is clear enough.