Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the merge-trunk-develop-pr, prepare-extension-release, and publish-extension-dev-build actions to use Node.js v20 #121

Conversation

eason9487
Copy link
Member

@eason9487 eason9487 commented Apr 25, 2024

Changes proposed in this Pull Request:

Part of #108

This PR upgrades the merge-trunk-develop-pr, prepare-extension-release, and publish-extension-dev-build actions to use Node.js v20.

📌 Checklist before merging (@eason9487)

  • Revert 3f7ee00 before merging this PR

Detailed test instructions:

prepare-extension-release action

  1. View a previous workflow run used v1 action
  2. View a test workflow run used updated action
  3. View the new release PR created by this action

merge-trunk-develop-pr action

  1. View a previous workflow run used v1 action
  2. View a test workflow run used updated action
  3. View the merging back PR created by this action

publish-extension-dev-build action

  1. View a previous workflow run used v1 action
  2. View a test workflow run used updated action
  3. View the dev build published by this action

@eason9487 eason9487 requested a review from a team April 25, 2024 10:17
@eason9487 eason9487 self-assigned this Apr 25, 2024
@eason9487 eason9487 mentioned this pull request Apr 25, 2024
26 tasks
Copy link
Contributor

@mikkamp mikkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, they look good to me. I don't see any of the warnings anymore about Node 16.

I was just curious about us running on ubuntu-latest. Release date of 24.04 is today, doesn't look like it's changed yet, but do we expect that to switch over without issues? I guess we can handle that separately if something does go wrong.

@eason9487
Copy link
Member Author

Thanks for the review, @mikkamp

I was just curious about us running on ubuntu-latest. Release date of 24.04 is today, doesn't look like it's changed yet, but do we expect that to switch over without issues?

I think this is the expected way - these actions are continuously compatible with the ubuntu-latest in GitHub Actions Runner. Most of the actions depend on Node.js, PHP or the common CLI, so as long as these dependencies are consistently compatible with ubuntu-latest, there should be no problems.

I guess we can handle that separately if something does go wrong.

Yes, a few actions depend on more particular CLI, such as jq, or services that are more prone to major changes, such as MySQL. I suppose we could just deal with it when it happens.

@eason9487 eason9487 merged commit 14e1521 into update/108-nodejs-v20 Apr 26, 2024
1 check passed
@eason9487 eason9487 deleted the update/108-nodejs-v20-github-actions-release-related branch April 26, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants