Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added license to readme #588 #589

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

added license to readme #588 #589

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9179f5c
added license to readme #588
cg-cnu Sep 7, 2017
6ddc9bd
added bugs and fixed repository url
cg-cnu Sep 7, 2017
1d207aa
changed the cmd and ctrl character to text. fixes #594
cg-cnu Sep 7, 2017
96eed72
changed control to ctrl
cg-cnu Sep 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,3 +104,7 @@ You're probably boarding on the Simpsons. You might want to escape North Korea t
## Contributers

We would love help on this project. If you are interested in helping out feel free to email [email protected] or submit a PR.

## License

ISC
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably mention licenses of 3rd party deps.

eg:

ISC, with 3rd party modules using MIT.

Then the second part can be extended if other libs are added.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @setpixel is ok with it I can add.
But AFAIK, we usually mention only the repo's license.
At least that's what they do in the js world 😄