Adding lambda support #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkku
reviewed
Jan 28, 2021
moxy.py
Outdated
| if index != -1: | ||
| replace_lambda_value = lambda_with_args(replace_lambda_value, index) | ||
| try: | ||
| code_object = compile(replace_lambda_value, "<lambda>", "eval") |
There was a problem hiding this comment.
I wonder if these compiled lambdas should be cached like compiled regexes are? Also, several lines of duplicated code between replace_lambda_in_dict and replace_lambda_in_content, maybe move to a function called by both?
There was a problem hiding this comment.
Great feedback, I will refactor accordingly.
arkku
reviewed
Jan 28, 2021
moxy.py
Outdated
| - An object (such as a dictionary) that can be dumped as JSON, in which case | ||
| it is converted to JSON. | ||
| """ | ||
| content_type = "application/json" | ||
| if isinstance(content, str): | ||
| try: | ||
| with open(content, "rb") as content_file: | ||
| if content.endswith("html"): | ||
| if content.endswith(".html"): |
There was a problem hiding this comment.
The lack of . was actually intentional to cover xhtml, shtml and such variants, but TBH probably not much of an issue in practice, and xhtml might need its own type anyway
There was a problem hiding this comment.
Thanks for the context; I'll go ahead and revert this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to perform a string substitution that could be more dynamic than what was already supported, so I added support for using lambda functions as replacement arguments.
While implementing my changes, I also made a slight modification to
encode_contentto better handle content passed to it and removed themitmproxynetimport since it is not necessary since this commit.