Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gradle actions; skip signing artifact in pre-merge check #23

Closed
wants to merge 1 commit into from

Conversation

nkly-wolt
Copy link
Collaborator

Replace gradle-build-action with setup-gradle as suggested in README. Remove gradle-wrapper-validation since setup-gradle performs it. Skip signing artifact in pre-merge check because pull request actions do not have access to repository secrets by default and we don't want to change it.

Replace gradle-build-action with setup-gradle as [suggested in
README][1]. Remove gradle-wrapper-validation since [setup-gradle
performs it][2]. Skip signing artifact in pre-merge check because [pull
request actions do not have access to repository secrets by default][3]
and we don't want to change it.

[1]: https://github.com/gradle/gradle-build-action?tab=readme-ov-file
[2]: https://github.com/gradle/actions/blob/main/docs/setup-gradle.md#gradle-wrapper-validation
[3]: https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/
@nkly-wolt nkly-wolt requested a review from muatik as a code owner August 22, 2024 14:57
@nkly-wolt nkly-wolt closed this Aug 22, 2024
@nkly-wolt nkly-wolt deleted the fix-ci-for-pull-requests branch August 22, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant