Make repository functions suspending #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkly-wolt
force-pushed
the
make-repository-interface-suspending
branch
from
165de73 to
c30d03d
Compare
Add `suspend` modifier to the functions in `IdempotentResponseRepository` interface. The change enables usage of async clients (e.g. [kreds][1] or jooq-r2dbc) in repository implementation without `runBlocking` while requiring almost no changes to existing blocking implementations. [1]: https://github.com/crackthecodeabhi/kreds
nkly-wolt
force-pushed
the
make-repository-interface-suspending
branch
from
c30d03d to
c18465b
Compare
muatik
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
suspendmodifier to the functions inIdempotentResponseRepositoryinterface. The change enables usage of async clients (e.g. kreds or jooq-r2dbc) in repository implementation withoutrunBlockingwhile requiring almost no changes to existing blocking implementations.