Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for RGBA in encode #251

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

drxddy
Copy link
Contributor

@drxddy drxddy commented Mar 22, 2024

This may not be your priority, since the last commit that modified C dir was 2 years ago, this pr is adding support for encoding 4-channel RGBA byte arrays for uint8_t *rgb param in the blurHashForPixels function.

modifies multiplyBasisFunction function to infer number of channels from bytesPerRow & width params instead of just 3 channels.

this will not affect performance or public API, it just extends with the support for RGBA pixel values, assuming the user sets bytesPerRow accordingly.

for existing users, assuming they used the correct bytesPerRow, it will continue to behave like before, as the channels gets equal to 3 as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant