Merge pull request #927 from sacereda/systrace-leak

Leak, returned value from GetThreadDescription not freed
wolfpld · Nov 19, 2024 · 759b4c3 · 759b4c3
2 parents e756fa7 + b9ee0d3
commit 759b4c3
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/public/client/TracySysTrace.cpp b/public/client/TracySysTrace.cpp
@@ -498,11 +498,11 @@ void SysTraceGetExternalName( uint64_t thread, const char*& threadName, const ch
         if( _GetThreadDescription )
         {
             PWSTR tmp;
-            _GetThreadDescription( hnd, &tmp );
-            char buf[256];
-            if( tmp )
+            if ( SUCCEEDED( _GetThreadDescription( hnd, &tmp ) ) )
             {
+                char buf[256];
                 auto ret = wcstombs( buf, tmp, 256 );
+                LocalFree(tmp);
                 if( ret != 0 )
                 {
                     threadName = CopyString( buf, ret );