Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmamba/2025.01.02 package update #38633

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Jan 2, 2025

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Jan 2, 2025
Copy link
Contributor Author

octo-sts bot commented Jan 2, 2025

Gen AI suggestions to solve the build error:

Based on the error, I'll provide a detailed analysis and solution:

• Detected Error: The build seems to get stuck after "using /tmp/apko-temp-4262173850/apko-x86_64.tar.gz for image layer" suggesting an issue with the CMake build process

• Error Category: Build Configuration

• Failure Point: CMake configuration/build step

• Root Cause Analysis:
The error occurs when building libmamba with Python bindings. Based on recent changes in the mamba repository (specifically PR #3702), there are new requirements for the build configuration.

• Suggested Fix:

  1. Update the cmake/configure step in the pipeline:
  - uses: cmake/configure
    with:
      opts: |
        -DBUILD_LIBMAMBA="ON" \
        -DBUILD_SHARED="ON" \
        -DBUILD_LIBMAMBAPY="ON" \
        -DBUILD_MICROMAMBA="ON" \
        -DBUILD_MAMBA_PACKAGE="ON" \
        -DCMAKE_BUILD_TYPE=Release \
        -DCONDA_REACTIVATE_CMD="__conda_activate reactivate"
  1. Add additional build dependencies:
environment:
  contents:
    packages:
      # Add these packages
      - ninja
      - python3-dev

• Explanation:

  1. The PR ruby3.2-console/1.17.4 package update #3702 indicates a change in how conda activation is handled
  2. The -DCONDA_REACTIVATE_CMD flag ensures proper conda activation behavior
  3. Additional build dependencies help with the Python binding compilation

• Additional Notes:

  • Consider adding -DCMAKE_POSITION_INDEPENDENT_CODE=ON if linking issues persist
  • The build system may need ninja for better parallel builds
  • Python development files are required for building the Python bindings

• References:

@developer-guy
Copy link
Member

its failing because the patch is not applicable anymore so we should update the patch here

@debasishbsws debasishbsws self-assigned this Jan 13, 2025
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Jan 13, 2025
@debasishbsws
Copy link
Member

Okay the test is failing now.

@debasishbsws
Copy link
Member

Upstream has modularized the libmambapy build, as seen in this PR.

Due to this change, we can no longer build with -DBUILD_LIBMAMBAPY="ON" in the main build step. Instead, it needs to be built separately in the Python version build step.

If we attempt to build it with the main package, the binding files end up in /home/build/libmamba rather than the intended location which is /usr/lib/python${{vars.py-version}}/sitepackage/libmambapy/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants