nodejs - be explicit about which python is used in build environment. #37223
+56
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When 'python3' and 'py3-jinja2' are installed in the build environment, there is not currently a way to guarantee that the 'python3' (a virtual package provided by python3.12, python3.13...) will be the same python version that fulfills the virtual package 'py3-jinja2'. The easiest way to guarantee this is to pin the python version as done here. python-3.12 (eol 2028) will outlive any of the currently available nodejs versions. So it would be sufficient for the 'py-version' value in all of these changes. Moving the last node lts (22) to 3.13 will give us a neweer python moving forward.
smoser
force-pushed
the
fix/py313-nodejs
branch
from
e36611b to
27579b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When 'python3' and 'py3-jinja2' are installed in the build environment, there is not currently a way to guarantee that the 'python3' (a virtual package provided by python3.12, python3.13...) will be the same python version that fulfills the virtual package 'py3-jinja2'.
The easiest way to guarantee this is to pin the python version as done here.
python-3.12 (eol 2028) will outlive any of the currently available nodejs versions. So it would be sufficient for the 'py-version' value in all of these changes. Moving the last node lts (22) to 3.13 will give us a neweer python moving forward.