Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby 3.4: interpreter & gem batch 1 #36408

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

justinvreeland
Copy link
Member

@justinvreeland justinvreeland commented Dec 11, 2024

This was created by renaming the 3.3 file to 3.4.

Turning the gemspec patches into files. See https://github.com/wolfi-dev/os/blob/main/ruby3.2-bouncy-castle-java/0001-add-gemspec.patch

Providing the base64, csv, and drb package from the main ruby package because they now conflict and some packages have implicit dependencies on them. Which means we either need to spot update failing packages or provide it from the interpreter that is already installing these gems.

@justinvreeland justinvreeland force-pushed the jvreeland/ruby-batch-1 branch 2 times, most recently from 42a275d to 40a255f Compare December 12, 2024 01:12
@octo-sts octo-sts bot added the bincapz/blocking Bincapz (aka malcontent) scan results detected CRITICALs on the packages. label Dec 12, 2024
@justinvreeland justinvreeland added the ai/skip-comment Stop AI from commenting on PR label Dec 12, 2024
@wolfi-dev wolfi-dev deleted a comment from octo-sts bot Dec 12, 2024
@justinvreeland justinvreeland removed the ai/skip-comment Stop AI from commenting on PR label Dec 12, 2024
@justinvreeland justinvreeland added the ai/skip-comment Stop AI from commenting on PR label Dec 12, 2024
@wolfi-dev wolfi-dev deleted a comment from octo-sts bot Dec 12, 2024
@wolfi-dev wolfi-dev deleted a comment from octo-sts bot Dec 12, 2024
@wolfi-dev wolfi-dev deleted a comment from octo-sts bot Dec 12, 2024
@wolfi-dev wolfi-dev deleted a comment from octo-sts bot Dec 12, 2024
@wolfi-dev wolfi-dev deleted a comment from octo-sts bot Dec 12, 2024
@octo-sts octo-sts bot added bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. and removed bincapz/blocking Bincapz (aka malcontent) scan results detected CRITICALs on the packages. labels Dec 12, 2024
@justinvreeland justinvreeland marked this pull request as ready for review December 12, 2024 20:09
Copy link
Member

@smoser smoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.

@justinvreeland
Copy link
Member Author

If you want to see the actual diff from the 3.3 copy you can look at justinvreeland@21c0c0d

Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a force merge, since this many files makes ci-sbom-validity time out and die.

@imjasonh imjasonh merged commit d14f582 into wolfi-dev:main Dec 12, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai/skip-comment Stop AI from commenting on PR bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants