Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-credential-oauth: new package #36081

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

purpleclay
Copy link
Contributor

Fixes: #36080

Related:

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • This PR links to the upstream project's support policy (e.g. endoflife.date)

For new version streams

  • The upstream project actually supports multiple concurrent versions.
  • Any subpackages include the version string in their package name (e.g. name: ${{package.name}}-compat)
  • The package (and subpackages) provides: logical unversioned forms of the package (e.g. nodejs, nodejs-lts)
  • If non-streamed package names no longer built, open PR to withdraw them (see WITHDRAWING PACKAGES)

For package updates (renames) in the base images

When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)

  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk images successfully build
  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk contain no obsolete (no longer built) packages
  • Upon launch, does apk upgrade --latest successfully upgrades packages or performs no actions

For security-related PRs

  • The security fix is recorded in the advisories repo

For version bump PRs

  • The epoch field is reset to 0

For PRs that add patches

  • Patch source is documented

Copy link
Member

@kranurag7 kranurag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the patch. requesting some changes inline.

git-credential-oauth.yaml Outdated Show resolved Hide resolved
git-credential-oauth.yaml Outdated Show resolved Hide resolved
git-credential-oauth.yaml Outdated Show resolved Hide resolved
@purpleclay purpleclay force-pushed the add-git-credential-oauth-package branch from fed9842 to b5520f2 Compare December 8, 2024 15:20
@purpleclay purpleclay force-pushed the add-git-credential-oauth-package branch from b5520f2 to 9dbfc88 Compare December 8, 2024 15:29
@ajayk ajayk added the approved-to-run A repo member has approved this external contribution label Dec 10, 2024
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Dec 10, 2024
@ajayk
Copy link
Member

ajayk commented Dec 11, 2024

@purpleclay Thanks for your contribution 🎉

@ajayk ajayk dismissed kranurag7’s stale review December 11, 2024 00:42

All the review comments have been addressed

@ajayk ajayk enabled auto-merge (squash) December 11, 2024 00:42
@ajayk ajayk merged commit c1bc479 into wolfi-dev:main Dec 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-to-run A repo member has approved this external contribution bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Wolfi Package Request]: git-credential-oauth
3 participants