Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3-aiohttp/3.11.10 package update #35967

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Dec 6, 2024

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Dec 6, 2024
Copy link
Contributor Author

octo-sts bot commented Dec 6, 2024

Gen AI suggestions to solve the build error:

Based on the error output and context provided, I'll analyze this build failure:

• Detected Error: No explicit error message is shown, but the git-checkout step appears to be failing silently

• Error Category: Version/Configuration

• Failure Point: Pipeline git-checkout step trying to fetch tag v3.11.10

• Root Cause Analysis: The git-checkout step is failing likely because the tag v3.11.10 doesn't exist in the upstream repository. Looking at the changelog provided, this appears to be a new version that may not be properly tagged yet.

• Suggested Fix:

  1. Verify the correct version and tag in the aiohttp repository
  2. Update the melange.yaml with the correct version/tag combination:
package:
  name: py3-aiohttp
  version: 3.11.9  # Change to latest released version
  
pipeline:
  - uses: git-checkout
    with:
      repository: https://github.com/aio-libs/aiohttp/
      tag: v3.11.9  # Match with latest released version
      expected-commit: # Update with correct commit hash for v3.11.9

• Explanation: The build is failing because it's trying to checkout a tag that doesn't exist. The version 3.11.10 appears to be new based on the changelog but may not be officially released and tagged yet.

• Additional Notes:

  • Always verify tags exist in upstream repository before updating versions
  • The bug fixes mentioned in the changelog suggest these changes are very recent
  • Consider waiting for official release tag before updating if this is a pre-release version

• References:

Copy link
Contributor Author

octo-sts bot commented Dec 8, 2024

Gen AI suggestions to solve the build error:

Based on the build error, I'll provide a detailed analysis and solution:

• Detected Error:

cc1: fatal error: aiohttp/_websocket/mask.c: No such file or directory
compilation terminated.
error: command '/usr/local/bin/x86_64-pc-linux-gnu-gcc' failed with exit code 1

• Error Category: Build Configuration

• Failure Point: During the Cython compilation step when building the aiohttp._websocket.mask extension

• Root Cause Analysis:
The build process is failing because the Cython-generated C files are not being created before the compilation step. This is happening because the Python Setup step isn't properly generating the Cython files for all components.

• Suggested Fix:
Modify the Python Setup step in the melange YAML to ensure all Cython files are generated:

- name: Python Setup
  runs: |
    mkdir -p .git
    python${{range.key}} tools/gen.py
    python${{range.key}} -m cython -3 aiohttp/*.pyx aiohttp/_websocket/*.pyx -I aiohttp
    rm -rf .git

• Explanation:
The original setup only compiled Cython files in the main aiohttp directory, but missed the files in the _websocket subdirectory. The modified command explicitly includes both directories, ensuring all necessary .c files are generated before the compilation step.

• Additional Notes:

  • The error is specifically related to the websocket mask implementation which is a performance-critical part of aiohttp
  • The .git directory creation/deletion is maintained as it's likely needed for version detection
  • The -I flag is kept to maintain include path settings

• References:

@hbh7 hbh7 self-assigned this Dec 9, 2024
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Dec 9, 2024
@hbh7 hbh7 requested a review from a team December 9, 2024 23:32
@mamccorm mamccorm merged commit e660164 into main Dec 10, 2024
14 checks passed
@mamccorm mamccorm deleted the wolfictl-a9f42da9-665c-459e-a6fe-888f5a97f79f branch December 10, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants