Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k3s/1.31.2.1-r4: cve remediation #35686

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Dec 3, 2024

Remediating this CVE required bumping quic-go, as well as go-libp2p. Similar bumps were made for another go package: #35698.

Additionally, we needed to set grpc to v1.68.0, as there are multiple instances of grpc in this project. It'd fail to bump them when left at v1.67.0 and complain some are already at v1.68.0.

Note k3s image tests may be failing in CI already (unrelated and pre-existing to this update). See here.


k3s/1.31.2.1-r4: fix GHSA-px8v-pp82-rcvr

Advisory data: https://github.com/wolfi-dev/advisories/blob/main/k3s.advisories.yaml

@octo-sts octo-sts bot added P1 This label indicates our scanning found High, Medium or Low CVEs for these packages. automated pr GHSA-px8v-pp82-rcvr go/bump request-cve-remediation k3s/1.31.2.1-r4 labels Dec 3, 2024
Copy link
Contributor Author

octo-sts bot commented Dec 3, 2024

Gen AI suggestions to solve the build error:

• Detected Error: undefined: http3.StreamCreator and related QUIC version errors

• Error Category: Dependency/Version

• Failure Point: Go build step failing due to incompatible versions between quic-go packages

• Root Cause Analysis: There appears to be a version mismatch between quic-go and its dependent packages. The error indicates that the HTTP/3 and QUIC implementations are not compatible with each other.

• Suggested Fix:

  1. Update the go.mod dependencies for quic-go related packages:
  - uses: go/bump
    with:
      deps: |
        github.com/quic-go/[email protected]
        github.com/quic-go/[email protected]
        github.com/libp2p/[email protected]

• Explanation:
The build is failing because of incompatible versions between quic-go packages. The StreamCreator interface and VersionNumber type were likely changed in recent versions. By explicitly setting compatible versions, we ensure all components use the same QUIC protocol implementation.

• Additional Notes:

  • QUIC protocol implementations are sensitive to version compatibility
  • The libp2p transport layer depends on specific quic-go versions
  • You may need to check k3s's upstream dependencies for the correct versions
  • Consider pinning these versions until upstream stabilizes their QUIC implementation

• References:

@mamccorm mamccorm self-assigned this Dec 12, 2024
@mamccorm mamccorm marked this pull request as draft December 12, 2024 00:15
octo-sts bot and others added 2 commits December 12, 2024 00:16
@mamccorm mamccorm force-pushed the cve-k3s-75cf6a6492b533da61c59ef9a6604f00 branch from 03bea50 to 3edbaa1 Compare December 12, 2024 00:16
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Dec 12, 2024
@mamccorm mamccorm marked this pull request as ready for review December 12, 2024 00:49
@mamccorm mamccorm requested a review from a team December 12, 2024 00:50
@luhring luhring merged commit 3815f70 into main Dec 12, 2024
14 checks passed
@luhring luhring deleted the cve-k3s-75cf6a6492b533da61c59ef9a6604f00 branch December 12, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. GHSA-px8v-pp82-rcvr go/bump k3s/1.31.2.1-r4 P1 This label indicates our scanning found High, Medium or Low CVEs for these packages. request-cve-remediation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants