Fix extraction of Message-IDs and fix function that sets the Thread-ID wrongly #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually, there has to be a "Message-ID" header in every e-mail. Unfortunately, sometimes, this field is also spelled "Message-Id" instead. So, adjust the readMail function such that it grep for spelling variant "Message-Id" if no "Message-ID" was found. Signed-off-by: Thomas Bock <[email protected]>
Usually, there has to be a "Message-ID" header in every e-mail. Unfortunately, sometimes, this field is also spelled "Message-Id" instead, and sometimes even "Message-id". So, adjust the readMail function such that it grep for spelling variant "Message-id" if neither "Message-ID" nor "Message-Id" was found. Signed-off-by: Thomas Bock <[email protected]>
If there are multiple parentIDs and iterating over them, just break if there exists a thread for one of the parentIDs. To achieve this, a `break` is needed instead of `next` within the `for` loop. Signed-off-by: Thomas Bock <[email protected]>
The inner loop in the the threads function used the same loop variable ("i") as the outer loop. As a consequence, at the end of the inner loop, i contains the last value of the inner loop iteration instead of the current outer loop i, and thus the thread id of a completely wrong message got updated. (However, this did, fortunately, not happen very often as the inner loop is executed only very very rarely.)
To fix this problem, rename the loop-variable of the inner loop to "j" instead.
Signed-off-by: Thomas Bock <[email protected]>
Sometimes the Message-ID is not in the same line as the key "Message-ID:" but in the subsequent line. This has not been considered yet and leads to an error as the Message-ID is set to an empty string. To fix this, check if the Message-ID is an empty string, and if so, extract the subsequent line from the header. As in most cases, the subsequent line is indented, remove the white space in front of the actual Message-ID.
Signed-off-by: Thomas Bock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we fix two bugs which caused wrong data when identifying mail threads:
Message-ID, namelyMessage-IdandMessage-iddecreased the number of such e-mails from 28,500 to 10). We provide a fix to cover these additional spelling variants if no header field spelledMessage-IDis available.breakas soon as we found one, instead of callingnextwhich could result in a not-available reference.i, as also the loop variable of the outer loop is called. That is, when returning from the inner loop, the outer loop accessesiagain but gets the last value of the inner loop instead of the current value of the outer loop, and, thus, is updating the wrong array element. We renamed the inner loop variable tojto avoid this problem.[As Codeface installs
tm-plugin-mailfrom your repository, this PR also acts as a direct bugfix to Codeface.]