Add support for loading user CA certs from a configurable Windows cert store. #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kareem-wolfssl
force-pushed
the
winSysCerts
branch
from
ed28b13
to
09027ea
Compare
ejohnstown
requested changes
Aug 1, 2024
apps/wolfsshd/configuration.c
Outdated
| @@ -377,7 +390,12 @@ static const CONFIG_OPTION options[NUM_OPTIONS] = { | |||
| {OPT_FORCE_CMD, "ForceCommand"}, | |||
| {OPT_HOST_CERT, "HostCertificate"}, | |||
| {OPT_TRUSTED_USER_CA_KEYS, "TrustedUserCAKeys"}, | |||
| {OPT_TRUSTED_SYSTEM_CA_KEYS, "TrustedSystemCAKeys"}, | |||
There was a problem hiding this comment.
For these new SSHD configuration options, are there OpenSSH server configuration option names for these? The items in this list are configuration items listed in sshd_config. If they aren't specifically on a list, we should prefix these with "wolfSSH".
| @@ -1019,9 +1037,24 @@ static int HandleConfigOption(WOLFSSHD_CONFIG** conf, int opt, | |||
| /* TODO: Add logic to check if file exists? */ | |||
| ret = wolfSSHD_ConfigSetUserCAKeysFile(*conf, value); | |||
| break; | |||
| case OPT_TRUSTED_SYSTEM_CA_KEYS: | |||
There was a problem hiding this comment.
Windows specific stuff should have a guard around it.
kareem-wolfssl
force-pushed
the
winSysCerts
branch
from
09027ea
to
1bc11e9
Compare
kareem-wolfssl
force-pushed
the
winSysCerts
branch
from
8e4feb2
to
3d6762a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for loading user CA certs from a configurable Windows cert store.
Depends on PR #577 and wolfSSL/wolfssl#7503
Draft for now, do not merge until customer confirms it works. Just looking for review + PR tests.