Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Public conflict reconciliation edge case on files with equal content but different metadata #430

Merged
merged 6 commits into from
Apr 23, 2024

Conversation

matheus23
Copy link
Member

This

  • improves the proptest setup to generate more diverse file system cases
  • fixes a bug where files with equal content but different metadata would not merge commutatively
  • factors out the PublicFile::merge function from PublicDirectory::merge_helper

@matheus23 matheus23 requested a review from a team as a code owner April 23, 2024 11:15
@matheus23 matheus23 self-assigned this Apr 23, 2024
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 57.50000% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 54.98%. Comparing base (dc0785a) to head (0a7f9f7).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
+ Coverage   54.43%   54.98%   +0.54%     
==========================================
  Files          57       57              
  Lines        4126     4156      +30     
  Branches     1028     1036       +8     
==========================================
+ Hits         2246     2285      +39     
+ Misses       1221     1196      -25     
- Partials      659      675      +16     
Files Coverage Δ
wnfs/src/private/directory.rs 68.92% <ø> (ø)
wnfs/src/private/file.rs 70.11% <100.00%> (ø)
wnfs/src/public/node/node.rs 66.07% <ø> (ø)
wnfs/examples/tiered_blockstores.rs 0.00% <0.00%> (ø)
wnfs/src/public/directory.rs 68.53% <45.45%> (+4.27%) ⬆️
wnfs/src/public/file.rs 63.46% <62.96%> (+3.46%) ⬆️

... and 2 files with indirect coverage changes

@matheus23 matheus23 merged commit a0bf23c into main Apr 23, 2024
12 checks passed
@matheus23 matheus23 deleted the matheus23/public-reconciliation-fixes branch April 23, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant