-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major refactor #59
Major refactor #59
Conversation
…s info is already provided in the interface arg
…o it't not confusing as hell
…n be supported without changing API
Do you plan to split the repos or transform this one into an overall layer shell lib collection? 🤔 |
I'm not sure. Single repo seems like a good idea. Probably wont change the name even if the scope grows, so as not to break links. Currently I'm thinking:
I'm open to feedback on all of this! |
If you would like to make some kind of common library, e.g. layer-shell-collection, it'd probably be better for someone searching for the godot lib 😅
Like reimplementing their wayland toplevel supports to become layer-shell? (That was how the gtk3 version worked afaik(?))
An issue or discussion would be nice to hear from people :P Perhaps other projects would be more open-minded on upstreaming though? There might not be a need for an external lib for long. Thanks for working on this project :) |
There's a lot in here, but the gist of it is I'm moving towards supporting more toolkits than just GTK and more protocols than just Layer Shell in the future. This refactor modernizes the code style, moves a lot of things around and adjusts abstractions boundaries to work better for this goal. The gtk4-layer-shell API is unchanged, the tests still pass and (hopefully) users should not be affected, though with this much code churn there's a chance of issues.