Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improved handling of active and pending topic dialogs #50

Merged
merged 8 commits into from
Jun 26, 2024
Merged

fix: improved handling of active and pending topic dialogs #50

merged 8 commits into from
Jun 26, 2024

Conversation

RoryPTB
Copy link
Contributor

@RoryPTB RoryPTB commented Jun 26, 2024

Major Fixes

  • Pending dialog no longer switches to active dialog when the input topic intersects with an active topic.
  • User cannot save if the validation of the text fields fails.

Minor Fixes

  • Downloader connection state boolean is renamed in CatalogueView.vue.
  • Server link now defaults with a http:// prefix.
  • User cannot save changes to an active topic's target if no changes were made.

@RoryPTB RoryPTB marked this pull request as ready for review June 26, 2024 16:38
@RoryPTB RoryPTB merged commit 5a28040 into main Jun 26, 2024
3 checks passed
@RoryPTB RoryPTB deleted the issue#47 branch June 26, 2024 16:39
@RoryPTB RoryPTB mentioned this pull request Jun 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RoryPTB