check more methods

wlandau · Dec 8, 2023 · 0c37ec5 · 0c37ec5
1 parent 31b4c78
commit 0c37ec5
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/R/crew_aws_batch_monitor.R b/R/crew_aws_batch_monitor.R
@@ -739,6 +739,18 @@ crew_class_aws_batch_monitor <- R6::R6Class(
           )
         }
       }
+      if (!length(out)) {
+        out[[length(out) + 1L]] <- tibble::tibble(
+          name = character(0L),
+          id = character(0L),
+          arn = character(0L),
+          status = character(0L),
+          reason = character(0L),
+          created = numeric(0L),
+          started = numeric(0L),
+          stopped = numeric(0L)
+        )
+      }
       out <- do.call(what = rbind, args = out)
       out$status <- tolower(out$status)
       out[out$status %in% status, ]

diff --git a/tests/monitor/jobs.R b/tests/monitor/jobs.R
@@ -26,6 +26,13 @@ x$submit(
 )
 job <- x$submit()
 out <- x$jobs()
+expect_true(tibble::is_tibble(x$submitted()))
+expect_true(tibble::is_tibble(x$active()))
+expect_true(tibble::is_tibble(x$inactive()))
+expect_true(tibble::is_tibble(x$pending()))
+expect_true(tibble::is_tibble(x$runnable()))
+expect_true(tibble::is_tibble(x$succeeded()))
+expect_true(tibble::is_tibble(x$failed()))
 expect_true(nrow(out) > 0L)
 expect_true(job$name %in% out$name)
 expect_true(job$id %in% out$id)