Skip to content

Commit

Permalink
Dropping MSnbase from DESCRIPTION
Browse files Browse the repository at this point in the history
I just can't pass checks with it. It requires netcdf which is a complicated install on Linux and it's not worth it for a few lines in the single vignette.
  • Loading branch information
wkumler committed Nov 30, 2023
1 parent 200c985 commit 87f7d1f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/r-check-cran.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,6 @@ jobs:
do
eval sudo $cmd
done < <(Rscript -e 'writeLines(remotes::system_requirements("ubuntu", "20.04"))')
## Force-install netcdf since it's missed by the system requirements
## but required for mzR & MSnbase
sudo -s apt-get install -y libnetcdf-dev
- name: Install BiocManager
run: |
Expand All @@ -74,8 +71,6 @@ jobs:
- name: Install dependencies
run: |
install.packages("stringi")
BiocManager::install("ncdf4")
BiocManager::install("mzR")
remotes::install_deps(dependencies = TRUE, repos=BiocManager::repositories())
remotes::install_cran("rcmdcheck")
shell: Rscript {0}
Expand Down
1 change: 0 additions & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ Suggests:
RSQLite,
reticulate,
BiocParallel,
MSnbase,
Spectra,
arrow,
microbenchmark,
Expand Down

0 comments on commit 87f7d1f

Please sign in to comment.