Wix.Core.Common: Bring back '.' capability for 'loc'/'wix' variables. #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify Common.TryParseWixVariable to only look for subsequent dots in the bind variables, the others (wix/loc) will just be considered as names that include dots. Also fixed up typo of 'identifier'. Signed-off-by: Bevan Weiss <[email protected]>
barnson
previously approved these changes
Sep 28, 2024
barnson
dismissed
their stale review
Assigned to @robmen and need to figure out how to trigger PR build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WiX v3 allowed for dots '.' in localization variables, bring this behaviour back.
Add test for Localization variable with multiple dots '.' within it.
Modify Common.TryParseWixVariable to only look for subsequent dots in the bind variables, the others (wix/loc) will just be considered as names that include dots.
Also fixed up typo of 'identifier'.
fixes wixtoolset/issues#8713