Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce early exception for overlength Windows Installer table name #558

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

bevanweiss
Copy link
Contributor

Introduces checks on Merge Modules and Products for overlength table names (> 31 characters).

Closes wixtoolset/issues#8645

Copy link
Member

@barnson barnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nitpicks.

src/api/wix/WixToolset.Data/ErrorMessages.cs Outdated Show resolved Hide resolved
src/api/wix/WixToolset.Data/ErrorMessages.cs Outdated Show resolved Hide resolved
@bevanweiss bevanweiss force-pushed the tablelength_exception branch 2 times, most recently from fb8189e to 44de83a Compare September 29, 2024 19:17
@robmen robmen requested a review from barnson December 25, 2024 03:27
@robmen robmen enabled auto-merge (rebase) December 25, 2024 03:27
robmen
robmen previously approved these changes Dec 25, 2024
barnson
barnson previously approved these changes Dec 25, 2024
@robmen robmen dismissed stale reviews from barnson and themself via a9b161c December 26, 2024 13:54
@robmen robmen force-pushed the tablelength_exception branch from 44de83a to a9b161c Compare December 26, 2024 13:54
@robmen robmen self-requested a review December 26, 2024 13:54
@robmen robmen merged commit 1afc0bd into wixtoolset:main Dec 26, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2024
@bevanweiss bevanweiss deleted the tablelength_exception branch December 26, 2024 23:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExtensionValidation: Early check on valid Table Name
3 participants