Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract logic from playgroundApp into managers #24

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

barak007
Copy link
Contributor

This PR separates the logic of project management into it's own class. that class does not depend on any FileSystemHandle it gets the fs for the project in the open project stage. this also means that the compilation service can be opened per project and we can possibly open more then one project at the same time.

I also moved all GUI related things to the main.tsx since the app can be potentially run standalone.

There are few more things to finish after this:

  1. move openFile types to preview manager
  2. get rid of getActiveProject in favor of GUI to handle multiple open projects.
  3. there will be a small degradation of open project time since we are now waiting for the services before rendering,
  4. ProjectHost can be a class and it will save few functions on the manager and cleanup the code even more.

@barak007 barak007 requested a review from AviVahl July 14, 2023 22:47
@barak007
Copy link
Contributor Author

@AviVahl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant