Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: esbuild plugin break after stylable error #2938

Merged
merged 2 commits into from
Feb 11, 2024
Merged

fix: esbuild plugin break after stylable error #2938

merged 2 commits into from
Feb 11, 2024

Conversation

barak007
Copy link
Collaborator

@barak007 barak007 commented Feb 8, 2024

in watch mode when there was transform error stylable esbuild plugin did not recover well this PR fixes that.

idoros
idoros approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@idoros idoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be much better to know when the build finish and not sleep fo 6+ seconds in the test

@barak007
Copy link
Collaborator Author

barak007 commented Feb 8, 2024

done

@barak007 barak007 requested a review from idoros February 8, 2024 21:02
@barak007 barak007 merged commit 27896fc into master Feb 11, 2024
12 checks passed
@barak007 barak007 deleted the barak/fix-esbuild branch February 11, 2024 09:51
barak007 added a commit that referenced this pull request Feb 11, 2024
@barak007
fix: esbuild plugin break after stylable error (#2938)
6199c02
@idoros idoros mentioned this pull request Feb 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idoros idoros Awaiting requested review from idoros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barak007 @idoros