feat(webpack)!: default to css-only depth #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoros
added
core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR flips the default stylesheet depth resolution mode from
CSS+JStoCSS.In the CSS+JS mode, the system followed the dependency graph into JavaScript/TypeScript files, allowing for easy customization of internal parts without the need for explicit imports within a stylesheet. For instance, a gallery could define a
.buttonclass without requiring an import of the Button component, indicating its intent to customize it.However, this mode has proven to be more complex to understand from a user perspective. Additionally, it is exclusively available ONLY within Stylable's Webpack integration, which poses challenges for Stylable in providing a unified cross-integration behavior.
While we anticipate deprecating this mode in the future, it will remain available for backward compatibility at present.