fix: align css depth mode to css+js mode #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoros
changed the title
barak007
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns the depth assignment for stylesheets in CSS-only mode with that of CSS+JS mode.
Previously, prior to this modification, CSS-only mode initiated at a depth level of 0, whereas CSS+JS mode initiated at a depth level of 1. This alteration has been implemented to ensure uniformity and will not impact existing usage. Its primary objective is to facilitate the transition to CSS-only mode as the default setting, thereby minimizing the need for extensive test refactoring.
Additionally, this PR addresses the issue of JS imports for values, formatters, and mixins, preventing them from adding extra depth, as they do not involve CSS overrides.
Furthermore, it prevents a depth increase in the case of circular imports for the stylesheet being calculated, as deeper circular imports are already handled.