Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: at-rule mixin collecting extra rules regression #2915

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

idoros
Copy link
Collaborator

@idoros idoros commented Oct 5, 2023

This PR resolves a regression where mixins defined within an at-rule, such as @st-scope, would inadvertently include extra rules that followed them.

This regression occurred during the handling of certain native-CSS nested mixin scenarios.

this fix will also be backported to version 5.

@idoros idoros added bug Unexpected behavior or exception core Processing and transforming logic mixin CSS and JS Mixins labels Oct 5, 2023
@idoros idoros requested a review from barak007 October 5, 2023 06:51
@idoros idoros self-assigned this Oct 5, 2023
@idoros idoros merged commit 080496f into master Oct 5, 2023
@idoros idoros deleted the ido/fix-nested-mixin-regression branch October 5, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected behavior or exception core Processing and transforming logic mixin CSS and JS Mixins
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants