Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(types)!: enhance type definitions for resolved CSS and JS values #2912

Merged
merged 5 commits into from
Oct 2, 2023
Merged

refactor(types)!: enhance type definitions for resolved CSS and JS values #2912

merged 5 commits into from
Oct 2, 2023

Conversation

idoros
Copy link
Collaborator

@idoros idoros commented Oct 1, 2023

This PR enhances the type definitions for resolved CSS and JS values in the following ways:

  1. The CSS resolved type now accurately represents the scenario where the symbol field can be undefined when the stylesheet exists, but the queried symbol definition is missing.
  2. The JS resolved symbol type (exported value) has been updated from the loose any type to the more precise unknown type.

@idoros idoros added API Programmatic API core Processing and transforming logic tech debt Updates, upgrades, stale code and work-arounds next-major Issues or PR related to the next major version labels Oct 1, 2023
@idoros idoros self-assigned this Oct 1, 2023
@idoros idoros requested a review from barak007 October 1, 2023 12:55
@idoros idoros linked an issue Oct 1, 2023 that may be closed by this pull request
When trying to resolve a non-existent symbol resolver returns _kind='css' and symbol is undefined #258
Closed
@idoros idoros requested a review from barak007 October 1, 2023 13:36
@idoros idoros merged commit 7a8b399 into master Oct 2, 2023
12 checks passed
@idoros idoros deleted the ido/improve-resolve-symbol-type branch October 2, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barak007 barak007 barak007 approved these changes

Assignees

@idoros idoros

Labels
API Programmatic API core Processing and transforming logic next-major Issues or PR related to the next major version tech debt Updates, upgrades, stale code and work-arounds
Projects
Stylable
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When trying to resolve a non-existent symbol resolver returns _kind='css' and symbol is undefined
2 participants
@idoros @barak007