refactor: use reference to eslint enum instead of string

wix · Feb 17, 2024 · dce5ada · dce5ada
1 parent 9f1d323
commit dce5ada
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/eslint-plugin-stylable/package.json b/packages/eslint-plugin-stylable/package.json
@@ -15,6 +15,7 @@
     "@file-services/node": "^8.3.3",
     "@stylable/core": "^5.16.0",
     "@typescript-eslint/utils": "^7.0.1",
+    "@typescript-eslint/scope-manager": "^7.0.1",
     "postcss-safe-parser": "^7.0.0"
   },
   "keywords": [

diff --git a/packages/eslint-plugin-stylable/src/stylable-es-lint.ts b/packages/eslint-plugin-stylable/src/stylable-es-lint.ts
@@ -8,6 +8,7 @@ import {
     ASTUtils,
     TSESTree as esTree,
 } from '@typescript-eslint/utils';
+import { DefinitionType } from '@typescript-eslint/scope-manager';
 import { createRequire } from 'node:module';
 import { pathToFileURL } from 'node:url';
 
@@ -78,8 +79,9 @@ export default createRule({
                                 return;
                             }
                             const { type } = varDefs.defs[varDefs.defs.length - 1];
-                            // eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison
-                            return local.name === varDefs.name && type === 'ImportBinding';
+                            return (
+                                local.name === varDefs.name && type === DefinitionType.ImportBinding
+                            );
                         });
 
                         if (!variable) {