chore: cleanup unnecessary cssVarsMapping passing

wix · Oct 24, 2023 · 9ceb2ff · 9ceb2ff
1 parent 3350e0e
commit 9ceb2ff
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 20 deletions.
diff --git a/packages/core/src/features/feature.ts b/packages/core/src/features/feature.ts
@@ -98,7 +98,6 @@ export interface FeatureHooks<T extends NodeTypes = NodeTypes> {
         context: FeatureTransformContext;
         ast: postcss.Root;
         transformer: StylableTransformer;
-        cssVarsMapping: Record<string, string>;
         path: string[];
     }) => void;
 }

diff --git a/packages/core/src/features/st-mixin.ts b/packages/core/src/features/st-mixin.ts
@@ -122,8 +122,8 @@ export const hooks = createFeature({
         }
         return isMarker;
     },
-    transformLastPass({ context, ast, transformer, cssVarsMapping, path }) {
-        ast.walkRules((rule) => appendMixins(context, transformer, rule, cssVarsMapping, path));
+    transformLastPass({ context, ast, transformer, path }) {
+        ast.walkRules((rule) => appendMixins(context, transformer, rule, path));
     },
 });
 
@@ -212,7 +212,6 @@ function appendMixins(
     context: FeatureTransformContext,
     transformer: StylableTransformer,
     rule: postcss.Rule,
-    cssPropertyMapping: Record<string, string>,
     path: string[] = []
 ) {
     const [decls, mixins] = collectRuleMixins(context, rule);
@@ -221,7 +220,7 @@ function appendMixins(
     }
     for (const mixin of mixins) {
         if (mixin.valid) {
-            appendMixin(context, { transformer, mixDef: mixin, rule, path, cssPropertyMapping });
+            appendMixin(context, { transformer, mixDef: mixin, rule, path });
         }
     }
     for (const mixinDecl of decls) {
@@ -359,7 +358,6 @@ interface ApplyMixinContext {
     mixDef: AnalyzedMixin & { valid: true };
     rule: postcss.Rule;
     path: string[];
-    cssPropertyMapping: Record<string, string>;
 }
 
 function appendMixin(context: FeatureTransformContext, config: ApplyMixinContext) {
@@ -475,8 +473,7 @@ function handleCSSMixin(
                 context.diagnostics,
                 mixDef.data.originDecl,
                 stVarOverride,
-                config.path,
-                config.cssPropertyMapping
+                config.path
             );
             collectOptionalArgs(
                 { meta: resolved.meta, resolver: context.resolver },

diff --git a/packages/core/src/functions.ts b/packages/core/src/functions.ts
@@ -23,7 +23,6 @@ export interface EvalValueData {
     node?: postcss.Node;
     meta: StylableMeta;
     stVarOverride?: Record<string, string> | null;
-    cssVarsMapping?: Record<string, string>;
     args?: string[];
     rootArgument?: string;
     initialNode?: postcss.Node;
@@ -63,7 +62,6 @@ export class StylableEvaluator {
             this.valueHook,
             context.diagnostics,
             context.passedThrough,
-            data.cssVarsMapping,
             data.args,
             data.rootArgument,
             data.initialNode
@@ -94,8 +92,7 @@ export function resolveArgumentsValue(
     diagnostics: Diagnostics,
     node: postcss.Node,
     variableOverride?: Record<string, string>,
-    path?: string[],
-    cssVarsMapping?: Record<string, string>
+    path?: string[]
 ) {
     const resolvedArgs = {} as Record<string, string>;
     for (const k in options) {
@@ -108,7 +105,6 @@ export function resolveArgumentsValue(
             transformer.replaceValueHook,
             diagnostics,
             path,
-            cssVarsMapping,
             undefined
         );
     }
@@ -125,7 +121,6 @@ export function processDeclarationValue(
     valueHook?: replaceValueHook,
     diagnostics: Diagnostics = new Diagnostics(),
     passedThrough: string[] = [],
-    cssVarsMapping: Record<string, string> = {},
     args: string[] = [],
     rootArgument?: string,
     initialNode?: postcss.Node
@@ -155,7 +150,6 @@ export function processDeclarationValue(
                         node,
                         meta,
                         stVarOverride: variableOverride,
-                        cssVarsMapping,
                         args,
                         rootArgument,
                         initialNode,
@@ -228,7 +222,6 @@ export function processDeclarationValue(
                         node,
                         meta,
                         stVarOverride: variableOverride,
-                        cssVarsMapping,
                         args,
                         rootArgument,
                         initialNode,
@@ -312,7 +305,6 @@ export function evalDeclarationValue(
     valueHook?: replaceValueHook,
     diagnostics?: Diagnostics,
     passedThrough: string[] = [],
-    cssVarsMapping?: Record<string, string>,
     args: string[] = [],
     getResolvedSymbols: (meta: StylableMeta) => MetaResolvedSymbols = createSymbolResolverWithCache(
         resolver,
@@ -329,7 +321,6 @@ export function evalDeclarationValue(
         valueHook,
         diagnostics,
         passedThrough,
-        cssVarsMapping,
         args
     ).outputValue;
 }
diff --git a/packages/core/src/stylable-transformer.ts b/packages/core/src/stylable-transformer.ts
@@ -314,7 +314,6 @@ export class StylableTransformer {
                 value: decl.value,
                 meta,
                 node: decl,
-                cssVarsMapping: cssVarsMapping.localToGlobal,
             }).outputValue;
         };
 
@@ -354,7 +353,6 @@ export class StylableTransformer {
             context: transformContext,
             ast,
             transformer: this,
-            cssVarsMapping: cssVarsMapping.localToGlobal,
             path,
         };
         if (this.experimentalSelectorInference) {