Add a configurable claim fee #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apbendi
force-pushed
the
claim-fee
branch
2 times, most recently
from
efdc337 to
03e00c3
Compare
alexkeating
reviewed
Oct 30, 2024
The claim fee is intentionally set as a fixed amount. The primary purpose of this fee is to act as a deterrent to "deposit sybiling", whereby a staker might spread funds out across many deposits in an attempt to reduce the liklihood or frequency of being "bumped" if his earning power decreases. Allowing the DAO to set a small, fixed fee would decrease the effective yield of small deposits without materially impacting a normal user.
|
Coverage after merging claim-fee into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||
alexkeating
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The claim fee is intentionally set as a fixed amount. The primary purpose of this
fee is to act as a deterrent to "deposit sybiling", whereby a staker might spread
funds out across many deposits in an attempt to reduce the liklihood or frequency
of being "bumped" if his earning power decreases. Allowing the DAO to set a small,
fixed fee would decrease the effective yield of small deposits without materially
impacting a normal user.