Add incentivized earning power update #30
Conversation
apbendi
force-pushed
the
add-incentivized-earning-power-update
branch
from
9572a04 to
ee1f4d5
Compare
There was a problem hiding this comment.
Hey @alexkeating, some mostly minor comments, but I did hit one failing test
test/GovernanceStaker.t.sol
Outdated
| govStaker.bumpEarningPower(_depositId, _tipReceiver, _requestedTip); | ||
| } | ||
|
|
||
| function testFuzz_RevertIf_NewEarningPowerIsGreaterThanTheCurrentEarningPower( |
There was a problem hiding this comment.
The name of this test makes it sound like the method should revert if the earning power is going up. It should have a name that's something like "Revert If: Unclaimed Rewards Are Less Than The Requested Tip When Earning Power Is Being Bumped Up"
test/GovernanceStaker.t.sol
Outdated
| govStaker.bumpEarningPower(_depositId, _tipReceiver, _requestedTip); | ||
| } | ||
|
|
||
| function testFuzz_RevertIf_NewEarningPowerIsLessThanTheCurrentEarningPower( |
There was a problem hiding this comment.
Similar to the prior test, this one needs a better name. "Revert If: Unclaimed Rewards Are Insufficient To Leave An Additional Bump Tip After Current Tip Is Paid When Earning Power Is Being Bumped Down"
There was a problem hiding this comment.
Small spelling error, it says "Maxc" instead of "Max"
There was a problem hiding this comment.
Yes, forgot to link the fix here 77e7a86
|
Coverage after merging add-incentivized-earning-power-update into main will be
Coverage Report
|
|||||||||||||||||||||||||
Description