Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Bug: Password hashing does not work on all node runtimes #75

Merged
merged 3 commits into from
May 10, 2024

Conversation

create-issue-branch[bot]
Copy link
Contributor

Original issue description

napi-rs/node-rs#816

This same error is present when username/password is enabled for deployments, to resolve this we should swap the node-rs/argon dep to a package such as noble-hashes as a runtime agnostic alternative for password hashing.

closes #74

@create-issue-branch create-issue-branch bot added bug Something isn't working enhancement New feature or request labels May 10, 2024
@create-issue-branch create-issue-branch bot changed the title Bug: Password hashing does not work on all node runtimes ✨ Bug: Password hashing does not work on all node runtimes May 10, 2024
@create-issue-branch create-issue-branch bot changed the title Bug: Password hashing does not work on all node runtimes ✨ Bug: Password hashing does not work on all node runtimes May 10, 2024
@Adammatthiesen Adammatthiesen marked this pull request as ready for review May 10, 2024 15:19
@Adammatthiesen Adammatthiesen requested a review from a team May 10, 2024 15:19
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments, aside from that looks good to me! 🫡

@Adammatthiesen
Copy link
Member

Just a couple of comments, aside from that looks good to me! 🫡

Updated in latest commit

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢🚢🚢

@Adammatthiesen Adammatthiesen merged commit 27c654a into main May 10, 2024
2 checks passed
@Adammatthiesen Adammatthiesen deleted the issue-0074 branch May 10, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Password hashing does not work on all node runtimes
2 participants