Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feat] Extend Authentication System ( username/password, more oAuth options, ability to extend? ) #67

Merged
merged 14 commits into from
May 10, 2024

Conversation

create-issue-branch[bot]
Copy link
Contributor

Original issue description

Our Current Auth system is currently only supporting Github oAuth using Lucia-Auth.

Lucia Auth also supports Username & Password as well as Standard oAuth. The goal of this Issue would be to implement a secure username/password system as well as either adding basic support for other oAuth provider options or creating an Extension system for the user to be able to pass in oAuth Configurations.

closes #13

@create-issue-branch create-issue-branch bot added enhancement New feature or request help wanted Extra attention is needed labels May 6, 2024
@create-issue-branch create-issue-branch bot changed the title [Feat] Extend Authentication System ( username/password, more oAuth options, ability to extend? ) ✨ [Feat] Extend Authentication System ( username/password, more oAuth options, ability to extend? ) May 6, 2024
@Adammatthiesen
Copy link
Member

Adammatthiesen commented May 7, 2024

Status Check - Preview Deployments are failing due to a update to the database Table schema that requires the user to either run astro db push --force-reset to reset their database data or create a new DB. This change allows me to add local user registration

So far Username/password authentication is working, next steps are to implement some extra oAuth providers as well as to create a new section on the user profile for creating a password(for those users who dont already have one) or changing a password.

@Adammatthiesen Adammatthiesen added in progress and removed help wanted Extra attention is needed labels May 7, 2024
@Adammatthiesen
Copy link
Member

Discord, and Google Authentication is now working as well!

@Adammatthiesen Adammatthiesen changed the title ✨ [Feat] Extend Authentication System ( username/password, more oAuth options, ability to extend? ) ✨ [Feat] Extend Authentication System ( username/password, more oAuth options, ~~ability to extend?~~ ) May 9, 2024
@Adammatthiesen Adammatthiesen changed the title ✨ [Feat] Extend Authentication System ( username/password, more oAuth options, ~~ability to extend?~~ ) ✨ [Feat] Extend Authentication System ( username/password, more oAuth options ) May 9, 2024
@Adammatthiesen
Copy link
Member

Auth0 is now added and working, that makes 4 oAuth providers and username/password authentication!

@Adammatthiesen
Copy link
Member

Adammatthiesen commented May 9, 2024

Note: This PR does not allow users to link already existing accounts to new oAuth accounts... that will be something for another PR as this one is already getting fairly complex and i want to try to keep some of these PR's from getting to massive

Note: Deployment preview is failing due to database schema mis-match! I will resolve by swapping the token to a new database before merge!

@Adammatthiesen Adammatthiesen marked this pull request as ready for review May 9, 2024 05:18
@Adammatthiesen Adammatthiesen requested a review from a team May 9, 2024 05:18
@create-issue-branch create-issue-branch bot changed the title ✨ [Feat] Extend Authentication System ( username/password, more oAuth options ) ✨ [Feat] Extend Authentication System ( username/password, more oAuth options, ability to extend? ) May 9, 2024
@create-issue-branch create-issue-branch bot changed the title ✨ [Feat] Extend Authentication System ( username/password, more oAuth options ) ✨ [Feat] Extend Authentication System ( username/password, more oAuth options, ability to extend? ) May 9, 2024
@Adammatthiesen Adammatthiesen requested a review from jdtjenkins May 9, 2024 10:57
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sick! so far looks good to me ✅

Copy link
Member

@jdtjenkins jdtjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Amazing work! Nicely done @Adammatthiesen !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] Extend Authentication System ( username/password, more oAuth options, ability to extend? )
3 participants