Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move back to EC #382

Merged
merged 10 commits into from
Nov 25, 2024
Merged

move back to EC #382

merged 10 commits into from
Nov 25, 2024

Conversation

Adammatthiesen
Copy link
Member

This pull request includes a major refactor of the codebase, focusing on removing the usage of Shiki for syntax highlighting and replacing it with Expressive Code, as well as updating dependencies and cleaning up unused code. The most important changes are detailed below:

Dependency Updates:

  • Updated versions for several packages in pnpm-workspace.yaml, including @astrojs/react, @astrojs/starlight, and astro.
  • Removed Shiki-related dependencies and added new dependencies for Expressive Code and related packages [1] [2].

Configuration Changes:

  • Removed Shiki configuration and related imports from www/docs/astro.config.mts and added new configuration for Expressive Code in www/docs/ec.config.mjs [1] [2] [3] [4] [5].

Component Refactor:

  • Removed Code.astro and PackageManagers.astro components, and replaced their usage with components from starlight-package-managers [1] [2] [3] [4] [5] [6].
  • Updated TursoCLI.astro to use the new Code component from @astrojs/starlight/components.

Documentation Updates:

  • Updated documentation files to reflect the new configuration and component changes, including markdoc.mdx and web-vitals.mdx [1] [2] [3] [4] [5] [6].

Package Management:

  • Removed the custom package manager command logic from pkg.ts and updated the relevant imports and usage throughout the codebase.

These changes collectively improve the maintainability and performance of the codebase by adopting a more modern syntax highlighting solution and removing outdated dependencies.

Copy link

changeset-bot bot commented Nov 24, 2024

⚠️ No Changeset found

Latest commit: 767438f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@studiocms-no-reply
Copy link
Member

Thank you for submitting your Pull Request, the following links will become available for preview shortly:

@withstudiocms-deployments
Copy link

withstudiocms-deployments bot commented Nov 24, 2024

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2024-11-25 01:38:37 CET

This commit refactors the dropdown, modal, and theme-helper components. It includes updates to the compiler options to include the 'dom' library. Additionally, it fixes some issues and adds new functionality to the components. The changes are made to improve the overall code structure and maintainability.
@louisescher louisescher self-requested a review November 24, 2024 13:19
@louisescher louisescher self-requested a review November 24, 2024 13:21
@louisescher louisescher self-requested a review November 24, 2024 13:29
@louisescher louisescher self-requested a review November 24, 2024 13:32
@louisescher louisescher self-requested a review November 24, 2024 14:18
@louisescher louisescher self-requested a review November 24, 2024 14:25
@louisescher louisescher self-requested a review November 24, 2024 14:37
@louisescher louisescher self-requested a review November 24, 2024 14:41
@louisescher louisescher self-requested a review November 24, 2024 14:46
@Adammatthiesen Adammatthiesen merged commit f6b1736 into issue-0304 Nov 25, 2024
3 checks passed
@Adammatthiesen Adammatthiesen deleted the re-add-ec branch November 25, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants