Refactor image handling and remove Unpic #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 045bfe7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thank you for submitting your Pull Request, the following links will become available for preview shortly:
|
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2024-10-27 01:41:52 CET |
Adammatthiesen
changed the title
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2024-10-27 01:41:44 CET |
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2024-10-27 01:56:13 CET |
louisescher
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on removing the Unpic image handler and simplifying the image handling logic across various packages. The most important changes include updates to the documentation, removal of dependencies, and refactoring of configuration schemas and integration adapters.
Documentation Updates:
README.md: Removed references to the Unpic Image handler and updated the toolset section to point to the.prototoolsfile for an up-to-date list of tools. [1] [2]Dependency and Configuration Changes:
packages/studiocms/package.json: Removed@unpic/astroandunpicdependencies. [1] [2]packages/studiocms_core/package.json: Removedunpicdependency.packages/studiocms_imagehandler/package.json: Removed@unpic/astroandunpicdependencies.packages/studiocms_core/src/schemas/config/imageService.ts: Removed the Unpic configuration schema and related options.Integration Adapter Removal:
packages/studiocms_imagehandler/src/adapters/cloudflare.ts: Removed the Cloudflare image handler integration.packages/studiocms_imagehandler/src/adapters/netlify.ts: Removed the Netlify image handler integration.packages/studiocms_imagehandler/src/adapters/node.ts: Removed the Node image handler integration.packages/studiocms_imagehandler/src/adapters/index.ts: Removed exports for the removed image handler integrations.These changes simplify the codebase by removing redundant image handling logic and dependencies, making the project easier to maintain and understand.