Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update config for biome and tsconfig, also implement a CI workflow that will also run future tests #355

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

Adammatthiesen
Copy link
Member

This pull request introduces a new continuous integration (CI) workflow, updates an existing workflow, and adds new CI-related scripts to the package.json file. The most important changes include setting up a CI workflow for linting, modifying the default value type in a workflow, and adding new scripts for CI linting and installation.

CI Workflow Setup

  • .github/workflows/ci.yml: Added a new CI workflow to lint the codebase using GitHub Actions, including steps for checking out code, setting up PNPM and Node, installing dependencies, and running the linting process.

Workflow Updates

CI Scripts

  • package.json: Added new scripts for CI linting (ci:lint) and installing dependencies with a frozen lockfile (ci:install).

Copy link

changeset-bot bot commented Oct 9, 2024

⚠️ No Changeset found

Latest commit: 601a9f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@studiocms-no-reply
Copy link
Member

Thank you for submitting your Pull Request, the following links will become available for preview shortly:

@Adammatthiesen
Copy link
Member Author

see withastro/astro#12167 (comment) for example

package.json Outdated Show resolved Hide resolved
Co-authored-by: Emanuele Stoppa <[email protected]>
Copy link
Member

@hkbertoson hkbertoson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Adammatthiesen Adammatthiesen merged commit a7c53f7 into main Oct 10, 2024
4 checks passed
@Adammatthiesen Adammatthiesen deleted the updatebiomeconfig branch October 10, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants