Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devcontainer config #350

Merged
merged 6 commits into from
Oct 7, 2024
Merged

Update devcontainer config #350

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d4c98ce
another update
Adammatthiesen Oct 7, 2024
6b91dbe
Update container version
Adammatthiesen Oct 7, 2024
3b41a86
Update Dockerfile
Adammatthiesen Oct 7, 2024
9bb3bd2
Update devcontainer.json
Adammatthiesen Oct 7, 2024
deb7a61
Update welcome-message.txt
Adammatthiesen Oct 7, 2024
c3a1dc0
Update welcome-message.txt
Adammatthiesen Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
FROM mcr.microsoft.com/devcontainers/javascript-node:0-20
FROM mcr.microsoft.com/devcontainers/javascript-node:1-20@sha256:f28172ab4f8cf57dacadc4d2aecf6d108bd9881617bd133b16ddcff6e6eef340

# We uninstall pnpm here, since we enable the corepack version in the postCreateCommand
# This ensures we respect the "packageManager" version in package.json
RUN npm uninstall -g pnpm && nvm install 20.14.0
RUN npm uninstall -g pnpm

COPY welcome-message.txt /usr/local/etc/vscode-dev-containers/first-run-notice.txt
# Install Proto CLI and it's dependencies
RUN apt-get update && apt-get install -y git unzip gzip xz-utils
RUN curl -fsSL https://moonrepo.dev/install/proto.sh | bash -s -- --yes

COPY welcome-message.txt /usr/local/etc/vscode-dev-containers/first-run-notice.txt
5 changes: 1 addition & 4 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,9 @@
"build": {
"dockerfile": "Dockerfile"
},
"postCreateCommand": "sudo corepack enable pnpm && pnpm config set store-dir /home/node/.pnpm-store && PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=1 pnpm install",
"postCreateCommand": "proto install && pnpm install",
"waitFor": "postCreateCommand",
"customizations": {
"codespaces": {
"openFiles": ["README.md"]
},
"vscode": {
"extensions": [
"astro-build.astro-vscode",
Expand Down