Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update first time PR action #308

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Update first time PR action #308

merged 1 commit into from
Sep 28, 2024

Conversation

Adammatthiesen
Copy link
Member

This pull request includes several updates to the .github/workflows/firsttimepr.yml file to enhance the workflow for welcoming new contributors. The most important changes include adding new permissions, updating the welcome message, and refining the logic for creating comments and handling errors.

Permissions update:

  • Added issues: write permission to the workflow configuration.

Message and logic improvements:

  • Updated the welcome message to include a link to the new Discord community.
  • Refined the description in the Discord embed message to use template literals for dynamic content. and fixing the main error that was caused due to this not being done in the first place, and it still expecting the input values from the old workflow
  • Removed the try-catch block that handled errors when creating comments, simplifying the code.

@Adammatthiesen Adammatthiesen requested review from a team as code owners September 28, 2024 00:00
Copy link

changeset-bot bot commented Sep 28, 2024

⚠️ No Changeset found

Latest commit: cfa1983

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Thank you for submitting your Pull Request, the following links will become available for preview shortly:

@Adammatthiesen Adammatthiesen added enhancement New feature or request ci Continuous Integrations / Automation awaiting review(s) chore labels Sep 28, 2024
Copy link
Member

@jdtjenkins jdtjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#yolo

@Adammatthiesen Adammatthiesen merged commit ae40c85 into main Sep 28, 2024
12 checks passed
@Adammatthiesen Adammatthiesen deleted the Adammatthiesen-patch-1 branch September 28, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore ci Continuous Integrations / Automation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants