Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Chore: Implement @matthiesenxyz/astrodtsbuilder for DTS generation #301

Merged
merged 7 commits into from
Sep 25, 2024
Merged

✨ Chore: Implement @matthiesenxyz/astrodtsbuilder for DTS generation #301

merged 7 commits into from
Sep 25, 2024

Conversation

create-issue-branch[bot]
Copy link
Contributor

Original issue description

Instead of doing a bunch of manual work to format it would be simpler to use my new Utility!

https://github.com/MatthiesenXYZ/astrodtsbuilder/blob/main/package/README.md

closes #286

@create-issue-branch create-issue-branch bot changed the title Chore: Implement @matthiesenxyz/astrodtsbuilder for DTS generation ✨ Chore: Implement @matthiesenxyz/astrodtsbuilder for DTS generation Sep 24, 2024
@create-issue-branch create-issue-branch bot changed the title Chore: Implement @matthiesenxyz/astrodtsbuilder for DTS generation ✨ Chore: Implement @matthiesenxyz/astrodtsbuilder for DTS generation Sep 24, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: c635029

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@studiocms/imagehandler Patch
@studiocms/dashboard Patch
@studiocms/renderers Patch
@studiocms/auth Patch
@studiocms/core Patch
studiocms Patch
@studiocms/frontend Patch
@studiocms/betaresources Patch
@studiocms/blog Patch
@studiocms/assets Patch
@studiocms/robotstxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

New deployment for the Packages/Playground DEMO has been queued and should be available shortly. To view the deployment once it is ready, click here

@Adammatthiesen Adammatthiesen marked this pull request as ready for review September 24, 2024 23:05
@Adammatthiesen Adammatthiesen requested review from a team as code owners September 24, 2024 23:06
louisescher
louisescher requested changes Sep 24, 2024
View reviewed changes
Copy link
Member

@louisescher louisescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked some grammar issues, other than that LGTM

packages/studiocms_auth/src/stubs/auth-config.ts Outdated Show resolved Hide resolved
packages/studiocms_auth/src/stubs/auth-helpers.ts Outdated Show resolved Hide resolved
packages/studiocms_core/src/stubs/dts.ts Outdated Show resolved Hide resolved
packages/studiocms_dashboard/src/utils/checkForWebVitalsPlugin.ts Outdated Show resolved Hide resolved
packages/studiocms_imagehandler/src/componentResolver.ts Outdated Show resolved Hide resolved
packages/studiocms_renderers/src/stubs/renderer-config.ts Outdated Show resolved Hide resolved
packages/studiocms_renderers/src/stubs/renderer-markdownConfig.ts Outdated Show resolved Hide resolved
packages/studiocms_renderers/src/stubs/renderer.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

New deployment for the Packages/Playground DEMO has been queued and should be available shortly. To view the deployment once it is ready, click here

@github-actions GitHub Actions
Copy link
Contributor

New deployment for the Packages/Playground DEMO has been queued and should be available shortly. To view the deployment once it is ready, click here

@github-actions GitHub Actions
Copy link
Contributor

New deployment for the Packages/Playground DEMO has been queued and should be available shortly. To view the deployment once it is ready, click here

@github-actions GitHub Actions
Copy link
Contributor

New deployment for the Packages/Playground DEMO has been queued and should be available shortly. To view the deployment once it is ready, click here

@github-actions GitHub Actions
Copy link
Contributor

New deployment for the Packages/Playground DEMO has been queued and should be available shortly. To view the deployment once it is ready, click here

@Adammatthiesen Adammatthiesen merged commit ebc297f into main Sep 25, 2024
8 checks passed
@Adammatthiesen Adammatthiesen deleted the issue-0286 branch September 25, 2024 14:35
@studiocms-no-reply studiocms-no-reply mentioned this pull request Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreyfus92 dreyfus92 dreyfus92 approved these changes

@louisescher louisescher louisescher approved these changes

@hkbertoson hkbertoson hkbertoson approved these changes

Assignees

@Adammatthiesen Adammatthiesen

Labels
chore enhancement New feature or request feat refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chore: Implement @matthiesenxyz/astrodtsbuilder for DTS generation
4 participants
@hkbertoson @louisescher @dreyfus92 @Adammatthiesen