Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup workflows #218

Merged
merged 19 commits into from
Jul 30, 2024
Merged

cleanup workflows #218

merged 19 commits into from
Jul 30, 2024

Conversation

Adammatthiesen
Copy link
Member

This PR, merges some workflows and cleans up others.

@Adammatthiesen Adammatthiesen self-assigned this Jul 27, 2024
@Adammatthiesen Adammatthiesen requested review from a team as code owners July 27, 2024 21:08
Copy link

changeset-bot bot commented Jul 27, 2024

⚠️ No Changeset found

Latest commit: cf4de3c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Adammatthiesen Adammatthiesen marked this pull request as draft July 27, 2024 21:11
@Adammatthiesen Adammatthiesen marked this pull request as ready for review July 27, 2024 21:12
Copy link
Contributor

@Adammatthiesen, thank you for opening this pull request!

Automated deployments are currently disabled for this project due to upstream issues. Please wait for a maintainer to review your changes and queue a deployment for you.

If you have any questions, feel free to ask!

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far LGTM, i'm just wondering if you test the changeset action cause you added a lot of extra steps to it.

@Adammatthiesen
Copy link
Member Author

So far LGTM, i'm just wondering if you test the changeset action cause you added a lot of extra steps to it.

I mean technically i just added a second job to the main action. It should still work since the second job has a very specific rule-set for it. But will be interesting to know if i am crazy or not...

.github/workflows/changeset.yml Outdated Show resolved Hide resolved
.github/workflows/changeset.yml Outdated Show resolved Hide resolved
.github/workflows/changeset.yml Outdated Show resolved Hide resolved
@Adammatthiesen Adammatthiesen requested a review from Fryuni July 29, 2024 01:14
@Adammatthiesen
Copy link
Member Author

!coauthor

Copy link
Contributor

Co-authored-by: Luiz Ferraz <[email protected]>
Co-authored-by: Paul Valladares <[email protected]>

@Adammatthiesen Adammatthiesen merged commit 2c8992c into main Jul 30, 2024
5 checks passed
@Adammatthiesen Adammatthiesen deleted the workflow-cleanup branch July 30, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants