Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove change of image's modified date #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aquino-a
Copy link

@aquino-a aquino-a commented Mar 28, 2022

I noticed that after organization of the photos, the modified date would be set to January 1, 1970.
Fixes issue #98.

@aquino-a aquino-a closed this Mar 28, 2022
@aquino-a aquino-a reopened this Mar 28, 2022
@AlexITC
Copy link
Contributor

AlexITC commented Apr 2, 2022

Please try adding a test to verify the change.

Thanks for your patience.

@aquino-a
Copy link
Author

aquino-a commented Apr 3, 2022

Would you want me to verify that the last modified date isn't changed after being organized?

@AlexITC
Copy link
Contributor

AlexITC commented Apr 3, 2022

Sure, the problem doesn't have much testing, hence, it would be ideal to start adding some.

By the way, the CI failed on Windows.

@aquino-a
Copy link
Author

aquino-a commented Apr 6, 2022

Ok
The CI failed due to an environment error where it was being built. The system couldn't find a file used to build the native image.

@AlexITC
Copy link
Contributor

AlexITC commented Apr 9, 2022

Makes sense, could you please add a simple test to verify your change?

@aquino-a
Copy link
Author

Yes, I will add eventually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants