Feature/otap as chunks #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vg-wp
reviewed
Sep 11, 2024
| if max_size is not None: | ||
| logging.info("Max scratchpad size is %d for %s" % (scratchpad.__len__(), gw_id)) | ||
| except KeyError: | ||
| logging.error("Unknow gateway in upload_scratchpad %s", gw_id) |
| @@ -286,6 +289,10 @@ def _on_status_gateway_received(self, client, userdata, message): | |||
| try: | |||
| gw = self._gateways[status.gw_id] | |||
| gw.online = (status.state == wmm.GatewayState.ONLINE) | |||
| gw.model = status.gateway_model | |||
| gw.version = status.gateway_version | |||
| gw.max_scratchpad_size=status.max_scratchpad_size | |||
There was a problem hiding this comment.
also typo just for missing spaces
GwendalRaoul
force-pushed
the
feature/otap_as_chunks
branch
from
b264871
to
c545784
Compare
It was complex for nothing and gateway parameter was wrongly interpreded
GwendalRaoul
force-pushed
the
feature/otap_as_chunks
branch
from
5366434
to
27cc50d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.