Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf python dependency to 4.X #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
- name: Install Protoc
uses: arduino/setup-protoc@v1
with:
version: '3.14.0'
version: '3.19.0'

- name: Generate proto files
run: |
Expand Down
8 changes: 5 additions & 3 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# 3.12.2 version is used as it is
# the version available in alpine 3.12 (for protobuf cpp version)
protobuf>=3.12.2,<4.0
# Protobuf version above major version 4 require the file to be compiled with
# protoc 3.19 or newer.
# TODO Alpine image currently support protoc 3.18+, so it is required to wait for an
# alpine image with updated protoc before a new image can be generated
protobuf>=4.0