Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix downloads when reloading file extension #3234

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix downloads when reloading file extension #3234

wants to merge 2 commits into from

Conversation

Denneisk
Copy link
Member

Downloads would break when reloading the file extension because it depended on a timer that never gets removed.

@thegrb93
Copy link
Contributor

thegrb93 commented Dec 30, 2024 •
edited
Loading

Doesn't the timer.create do the same thing as the timer.adjust here?

@Denneisk
Copy link
Member Author

Yeah but I thought it might be marginally faster to use timer.Adjust.

@thegrb93
Copy link
Contributor

Not when an additional timer.Exists call is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegrb93 thegrb93 thegrb93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Denneisk @thegrb93