Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2 Pickup events #3229

Merged
merged 1 commit into from
Dec 27, 2024
Merged

E2 Pickup events #3229

merged 1 commit into from
Dec 27, 2024

Conversation

Astralcircle
Copy link
Contributor

Events for tracking the pickup/drop of entities using the physgun, gravity gun, and hands.

@deltamolfar
Copy link
Contributor

I think having just 2 event playerPickup and playerDrop + the source of pickup/drop in string var or whatever would be better, as it would allow for single place of logic.
Say I want to track if prop is being held/dropped by hands OR gravgun. Having to track that in 4 events, instead of 2 + simple if statement seems worse to me

@unknao
Copy link
Contributor

unknao commented Dec 25, 2024

Never have i wanted something so badly and not known about it, though i think it should also include OnPhysgunReload.

@thegrb93
Copy link
Contributor

Does the helper have events? Need to update helper if so

@deltamolfar
Copy link
Contributor

Nope, it doesn't

@thegrb93 thegrb93 merged commit 525512e into wiremod:master Dec 27, 2024
1 check passed
@Astralcircle Astralcircle deleted the events branch December 27, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants