Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holo net improvements #3210

Merged
merged 6 commits into from
Dec 30, 2024
Merged

Conversation

wrefgtzweve
Copy link
Contributor

@wrefgtzweve wrefgtzweve commented Dec 7, 2024

Improves networking of various holo* functions, also adds MAX_EDICT_BITS to standardize ent index networking which uses the new MAX_EDICT_BITS global enum in gmod which isn't in basegame yet but will be with the next update, thus the fallback.

@wrefgtzweve wrefgtzweve marked this pull request as draft December 7, 2024 17:40
@wrefgtzweve wrefgtzweve marked this pull request as ready for review December 10, 2024 22:10
@Denneisk
Copy link
Member

Denneisk commented Dec 11, 2024

Do we really need our own copy of MAX_EDICT_BITS? I think temporarily defining it as a global (and removing it later when everyone updates) would be fine.

@wrefgtzweve
Copy link
Contributor Author

Would work too sure

@Astralcircle
Copy link
Contributor

Maybe you could also make #3164 part of this PR? The issue with that PR was that the entity limit could increase, but now it’s no longer a concern.

@wrefgtzweve
Copy link
Contributor Author

wrefgtzweve commented Dec 15, 2024

Yeah i was considering doing that, i was thinking of doing it in a follow up pr with possibly more of them but it'll fit in this pr fine

@thegrb93 thegrb93 merged commit 45c2987 into wiremod:master Dec 30, 2024
1 check passed
@wrefgtzweve wrefgtzweve deleted the holo-net-improvements branch December 30, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants