Remove arguments overloading in SetDrawColor and SetTextColor #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deltamolfar
reviewed
Oct 25, 2024
| @@ -105,7 +105,7 @@ if CLIENT then | |||
| -- This is overridable by other wire entities which want to customize the overlay, but generally you shouldn't override it | |||
| function ENT:DrawWorldTipOutline( pos ) | |||
| draw.NoTexture() | |||
| surface.SetDrawColor(Color(25,25,25,200)) | |||
| surface.SetDrawColor(25, 25, 25, 200) | |||
There was a problem hiding this comment.
Why that, instead of creating local color beforehand on outer scope, if color is static?
There was a problem hiding this comment.
There is no difference, and we also save a bit of code performance because we don't call __index method.
Also check this
There was a problem hiding this comment.
Well that's interesting. Thanks for sharing :)
|
Garry adding the most unappreciated class ever. |
Denneisk
approved these changes
Oct 25, 2024
thegrb93
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Micro-optimization