Merge Wire Extras' holoAnim core with the vanilla hologram core #3113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegrb93
requested changes
Aug 5, 2024
Comment on lines
1289
to
1293
| function Holo.ent:Think() | ||
| OldThink(self) | ||
| self:NextThink(CurTime()) | ||
| return true | ||
| end |
There was a problem hiding this comment.
Should add some logic for animations to the hologram ENT:Think instead of doing this hackery
|
It would be nice to have the ability to stop the entity from thinking too much when an animation is over, though i don't know any way to check if its over and not screw over looping animations. |
thegrb93
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People have been talking about porting Wire Extras e2 cores on and off on the Wiremod discord for quite a while since Wire Extras might be undesireable for some server owners that don't want the abuseability of some of the other things added by it.
I fixed up the broken pose parameters and added some new functions that should make working with hologram animations easier.